fix: scope issues count to tracked repos#439
Open
corevibe555 wants to merge 3 commits intoentrius:testfrom
Open
fix: scope issues count to tracked repos#439corevibe555 wants to merge 3 commits intoentrius:testfrom
corevibe555 wants to merge 3 commits intoentrius:testfrom
Conversation
corevibe555
force-pushed
the
fix/issue-422-scoped-open-issue-count
branch
2 times, most recently
from
b900023 to
ab0af63
Compare
corevibe555
changed the title
Author
|
@anderdc Would you review this PR? |
corevibe555
force-pushed
the
fix/issue-422-scoped-open-issue-count
branch
from
646a103 to
135386a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #422
Summary
The open-issue spam multiplier in
gittensor/validator/issue_discovery/scoring.pywas gated onUser.issues.totalCount, an unscoped global count that includes personal projects, forks, and non-tracked upstream repositories. Miners with legitimate open issues anywhere on GitHub could be silently hard-zeroed on their entireissue_discovery_score, even when every tracked-repo filing was clean.Related Issues
Closes #422
Type of Change
Testing
Added:
tests/utils/test_count_tracked_open_issues.py— 7 unit tests:Results: 7/7 new tests pass. Broader validator suite (70 pre-existing tests) remains green. The 6 collection errors in the validator suite are pre-existing
tree_sitterimport failures unrelated to this change.** Manual testing**
I have tested using three repos entrius/gittensor, entrius/gittensor-ui, corevibe555/corevibe555.
The screenshot shows the personal repo issue is ignored correctly.
Checklist
total_open_issuescolumn repurposed, not renamed)