refactor: remove dead extract_pr_number_from_url function#437
Merged
anderdc merged 6 commits intoentrius:testfrom Apr 15, 2026
Merged
Conversation
Contributor
Author
|
Hi, @anderdc |
Contributor
Author
|
Will fix it soon. |
wdeveloper16
force-pushed
the
refactor/remove-dead-extract-pr-number-from-url
branch
from
5ab575b to
329943c
Compare
Contributor
Author
|
Just done! |
anderdc
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract_pr_number_from_urlinutils/github_api_tools.py:1131-1143is never called anywhere.The same logic (and more — plain digit strings) is already covered by the actively used
parse_pr_numberinissue_commands/vote.py. Deletes the dead function.Test plan
pytest tests/cli/ tests/utils/— no new failures