Skip to content

Move duplicated ISO timestamp parser to shared datetime_utils#412

Closed
statxc wants to merge 2 commits intoentrius:testfrom
statxc:refactor/unify-timestamp-parsing
Closed

Move duplicated ISO timestamp parser to shared datetime_utils#412
statxc wants to merge 2 commits intoentrius:testfrom
statxc:refactor/unify-timestamp-parsing

Conversation

@statxc
Copy link
Copy Markdown

@statxc statxc commented Apr 14, 2026

Description

  • Extract _parse_iso() from validator/issue_discovery/repo_scan.py into validator/utils/datetime_utils.py as parse_iso()
  • Import the shared function in repo_scan.py

@anderdc
Copy link
Copy Markdown
Collaborator

anderdc commented Apr 14, 2026

Closing this one out:

  • _parse_iso isn't duplicated anywhere, it only exists in repo_scan.py
  • parse_github_timestamp_to_cst in datetime_utils.py is a different function (converts to CST, not just parsing)
  • Moving a single-use private helper to a shared module is premature, adds an import hop for no benefit
  • If we need parse_iso elsewhere later, that's the time to extract it

@anderdc anderdc closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants