Refactor: unify config loading by reusing load_config from helpers#410
Closed
volcano303 wants to merge 1 commit intoentrius:testfrom
Closed
Refactor: unify config loading by reusing load_config from helpers#410volcano303 wants to merge 1 commit intoentrius:testfrom
volcano303 wants to merge 1 commit intoentrius:testfrom
Conversation
Move config loading in post.py and contract address resolution in issue_competitions.py to use centralized helpers, eliminating duplicated logic and ensuring consistent priority (CLI arg > env var > default).
volcano303
force-pushed
the
refactor/unify-config-loading
branch
from
82f428e to
82e39f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_load_config_value()incli/miner_commands/post.pywith a call to the existingload_config()fromcli/issue_commands/helpers.pyget_contract_address()invalidator/utils/issue_competitions.pywith a call to the existingget_contract_address()fromcli/issue_commands/helpers.py