fix: clean up stale PR state when repo removed or PR merged to non-acceptable branch#399
Closed
jamesrayammons wants to merge 1 commit intoentrius:testfrom
Closed
fix: clean up stale PR state when repo removed or PR merged to non-acceptable branch#399jamesrayammons wants to merge 1 commit intoentrius:testfrom
jamesrayammons wants to merge 1 commit intoentrius:testfrom
Conversation
jamesrayammons
force-pushed
the
fix/stale-pr-state-cleanup
branch
from
fa7eb6c to
ccf0cad
Compare
anderdc
force-pushed
the
fix/stale-pr-state-cleanup
branch
from
ccf0cad to
618cf36
Compare
…ceptable branch When a repository is removed from master_repositories.json, existing PR records in the database kept their old pr_state indefinitely. Similarly, PRs merged to non-acceptable branches were skipped during evaluation, leaving stale OPEN state in the DB. Two cleanup mechanisms added: - DELETE PR records for repos no longer in master_repositories - UPDATE pr_state for skipped merged PRs to reflect actual GitHub state Fixes entrius#398
jamesrayammons
force-pushed
the
fix/stale-pr-state-cleanup
branch
from
618cf36 to
ecfbea7
Compare
Author
|
@anderdc @LandynDev could you review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a repository is removed from
master_repositories.json, existing PR records in the database kept their oldpr_stateindefinitely. Similarly, PRs merged to non-acceptable branches were skipped during evaluation, leaving staleOPENstate in the DB.Two cleanup mechanisms added:
master_repositoriespr_statefor skipped merged PRs to reflect actual GitHub stateRelated Issues
Fixes #398
Type of Change
Testing
10 tests added in
tests/validator/test_stale_pr_cleanup.py:Checklist