fix: replace mutable default argument in get_all_uids#391
Closed
t7929375-eng wants to merge 3 commits intoentrius:testfrom
Closed
fix: replace mutable default argument in get_all_uids#391t7929375-eng wants to merge 3 commits intoentrius:testfrom
t7929375-eng wants to merge 3 commits intoentrius:testfrom
Conversation
Covers: - Basic UID enumeration with and without exclusions - UID 0 forced inclusion - Regression: default exclude list not shared across calls - Edge case: empty metagraph
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_all_uids()uses a mutable default argument (exclude: List[int] = []). This is a well-known Python anti-pattern (W0102) — the shared default object is permanently corrupted if mutated.Replaced with
Optional[List[int]] = Noneand an explicit guard.Type of Change
Testing
tests/utils/test_uids.py(UID enumeration, exclusion, UID 0 forced inclusion, regression test for shared default, empty metagraph)ruff checkpassespyrightpassesChecklist
cc @anderdc @LandynDev