Skip to content

refactor: remove unused CommitTrendChart component#291

Closed
wdeveloper16 wants to merge 1 commit intoentrius:testfrom
wdeveloper16:refactor/remove-dead-code
Closed

refactor: remove unused CommitTrendChart component#291
wdeveloper16 wants to merge 1 commit intoentrius:testfrom
wdeveloper16:refactor/remove-dead-code

Conversation

@wdeveloper16
Copy link
Copy Markdown
Contributor

@wdeveloper16 wdeveloper16 commented Apr 15, 2026

Summary

  • Deletes src/components/dashboard/CommitTrendChart.tsx — exported from the dashboard barrel but never imported anywhere in the app (0 usages across the entire codebase)
  • Removes its two-line re-export from src/components/dashboard/index.ts

Net: 2 files changed, 195 lines deleted.

Test plan

  • npm run format:check — passes
  • npm run lint — passes (0 warnings)
  • npm run build — clean build, no TS errors

Copy link
Copy Markdown

@xiao-xiao-mao xiao-xiao-mao bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes the unused CommitTrendChart component exports and the unused TEXT_OPACITY export from the theme. The cleanup looks safe and straightforward. No issues found from the diff.

@wdeveloper16 wdeveloper16 force-pushed the refactor/remove-dead-code branch from e824c71 to d25590a Compare April 15, 2026 13:38
@wdeveloper16 wdeveloper16 changed the title refactor: remove unused CommitTrendChart component and TEXT_OPACITY export refactor: remove unused CommitTrendChart component Apr 15, 2026
@anderdc
Copy link
Copy Markdown
Collaborator

anderdc commented Apr 15, 2026

Closing — CommitTrendChart is actively used by open PR #284. Merging this deletion would break that work.

@anderdc anderdc closed this Apr 15, 2026
@wdeveloper16
Copy link
Copy Markdown
Contributor Author

wdeveloper16 commented Apr 15, 2026

Hi, @anderdc
I noticed that the related PR: #284 was closed as not planed.
Actually, I also thought the dashboard redesign is really not necessary.
Would be you able to reopen and consider this PR again, since the commitTrendChart is really unused? 😉
Hope to keep clean and concise codebase by removing unused file or component as well.

@anderdc anderdc added the refactor Code restructuring without behavior change label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Code restructuring without behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants