You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes#288 . Two small corrections to the Repository → Pull Requests table:
Score column on OPEN PRs now shows the PR's collateral score (already on CommitLog as collateralScore) styled in the open-status color and prefixed with - to signal it's a penalty. Open PRs no longer render a uniform 0.0000 column. Merged and closed PRs are unchanged - still show score.
The "Merged" header becomes "Date" and the cell now shows mergedAt for merged PRs and prCreatedAt otherwise. The column is no longer a sea of dashes on All / Open / Closed filters.
Why
Open PRs haven't been fully scored yet, so their score field is 0. Showing 0.0000 gave miners and reviewers no actionable information. The collateral score is what's actively being applied to the miner while the PR sits open — it's the meaningful number.
The Merged column was wasted whitespace for any PR state other than MERGED. Renaming to Date and backfilling with the creation date keeps the column useful across every filter.
Score cell now branches on prState: OPEN + non-zero collateralScore → display -X.XXXX in status.open color with a tooltip; otherwise display score.toFixed(4) in primary text color (current behavior).
Header cell renamed Merged → Date.
Date cell now uses pr.mergedAt ?? pr.prCreatedAt.
No new data fetched, no new dependencies. CommitLog already exposes collateralScore and prCreatedAt.
Type of Change
Bug fix / UX correctness
Testing
npm run build
npm run lint:fix
Manual on any repository with a mix of PR states:
Score column: open PRs show -{collateral} in the open-status color with a tooltip; merged / closed rows show the normal score.
Open PRs with collateralScore = 0 (rare edge case) fall back to showing 0.0000 rather than -0.0000.
Date column: merged rows show merge date; open / closed rows show creation date; no more dashes under normal data.
Hovering a negative collateral cell surfaces the tooltip "Collateral score applied while this PR is open".
Mobile viewport: column width doesn't change meaningfully.
Hi, @anderdc
I created #288 issue and also opened a PR - #289 but my PR become duplicated due to #295 .
Actually #295 was created after #289, so to be precise, #295 must be closed first.
Please review quickly and correctly. I appreciate.
Closing — this fixes the same table that your #283 modifies. Please fold the collateral display + Merged→Date rename into #283 alongside the sortable columns, and fix the score comparator to use collateralScore for open PRs (same pattern as getEffectiveScore in #279). No reason for two PRs against the same file.
Hi, @anderdc
Yes, you are right, Could you reopen the PR again? Actually current PR mention about more adaptive term in the list.
They can contain changes in the same file but their features are different.
I pushed again without conflict. I want you to review again.
Closing — this fixes the same table that your #283 modifies. Please fold the collateral display + Merged→Date rename into #283 alongside the sortable columns, and fix the score comparator to use collateralScore for open PRs (same pattern as getEffectiveScore in #279). No reason for two PRs against the same file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactorCode restructuring without behavior change
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #288 . Two small corrections to the Repository → Pull Requests table:
CommitLogascollateralScore) styled in the open-status color and prefixed with-to signal it's a penalty. Open PRs no longer render a uniform0.0000column. Merged and closed PRs are unchanged - still showscore.mergedAtfor merged PRs andprCreatedAtotherwise. The column is no longer a sea of dashes on All / Open / Closed filters.Why
scorefield is0. Showing0.0000gave miners and reviewers no actionable information. The collateral score is what's actively being applied to the miner while the PR sits open — it's the meaningful number.What changed
src/components/repositories/RepositoryPRsTable.tsx:prState: OPEN + non-zerocollateralScore→ display-X.XXXXinstatus.opencolor with a tooltip; otherwise displayscore.toFixed(4)in primary text color (current behavior).Merged→Date.pr.mergedAt ?? pr.prCreatedAt.No new data fetched, no new dependencies.
CommitLogalready exposescollateralScoreandprCreatedAt.Type of Change
Testing
npm run buildnpm run lint:fix-{collateral}in the open-status color with a tooltip; merged / closed rows show the normal score.collateralScore = 0(rare edge case) fall back to showing0.0000rather than-0.0000.Checklist
Video to upload
3.mp4