fix: hide default webkit scrollbar button artifact in repo weights table#281
Merged
anderdc merged 2 commits intoentrius:testfrom Apr 15, 2026
Merged
Conversation
Contributor
Author
|
@anderdc can you please review my PR and let me know your feedback? |
anderdc
requested changes
Apr 15, 2026
Collaborator
anderdc
left a comment
There was a problem hiding this comment.
The description says this fixes a Chrome ::-webkit-scrollbar-button artifact, but the diff just swaps a borderBottom for a margin on the header wrapper Box. Can you clarify how removing a border between the header and the table addresses a scrollbar pseudo-element issue? The root cause described doesn't match the change.
Contributor
Author
|
Hi @anderdc |
anderdc
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #280
Summary
Fixes a visual artifact on the Onboard → Repositories tab: when the table is scrollable (e.g. Rows ≥ 25), a thin line appears above the vertical scrollbar in the top-right corner.
Root cause
In
src/components/repositories/RepositoryWeightsTable.tsx, the<Box>wrapping the description + controls has aborderBottom: '1px solid rgba(255,255,255,0.1)'. That wrapper spans the full component width. TheTableContainerbeneath it isoverflow: auto, so when the scrollbar appears it narrows the scrollable area by ~8px — but the border above doesn't shrink with it, leaving ~8px of border hanging over the top of the scrollbar track. That's the "dash" in the issue.The sibling
LanguageWeightsTabledoesn't have this bug because it separates its controls from its table withmb: 3spacing instead of a full-width border, and the sticky header cells supply their own per-cellborderBottomthat naturally stops where the scrollbar starts.Fix
Match the pattern used by
LanguageWeightsTable:borderBottom: '1px solid rgba(255,255,255,0.1)'from the outer header wrapper inRepositoryWeightsTable.tsx.mb: 3for breathing room.The sticky-header
borderBottomon eachTableCellalready provides the visible separator between controls and rows, and it correctly shrinks with the scrollable area.Type of Change
Testing
npm run buildnpm run lint:fix/onboard?tab=repositories: set Rows to 25 → scrollbar appears → no dash above it./onboard?tab=languages: unchanged (verifies the fix just aligns the two tabs).Checklist
LanguageWeightsTableScreenshots