refactor(pages): replace hardcoded colors with theme tokens#263
refactor(pages): replace hardcoded colors with theme tokens#263anderdc merged 4 commits intoentrius:testfrom
Conversation
anderdc
left a comment
There was a problem hiding this comment.
The page-level token swaps are good — those files should be using the theme tokens we already have. Two things to fix:
- Drop the
palette.alertaddition from theme.ts. Three tokens for one component isn't worth a new palette section. Usealpha(STATUS_COLORS.warningOrange, 0.08)and friends inline, or use the existingstatus.warning/status.warningOrangetokens directly. text.disableddoesn't exist in the theme. Used in 4 places inRepositoriesPage.tsx. The palette hastext.primary,text.secondary,text.tertiary— pick the closest match or usealpha(theme.palette.text.primary, 0.3)to preserve the original appearance.
Also no CI checks ran on this branch — push or retrigger so build/format pass before re-review.
anderdc
left a comment
There was a problem hiding this comment.
Previous feedback on palette.alert and text.disabled is addressed — those are gone.
New issue: this PR bundles two unrelated changes. The title says "replace hardcoded page colors with theme tokens" but half the diff is a new ensureArray / useArrayApiQuery API safety layer across 7 API files. These should be separate PRs — the API changes touch shared data-fetching hooks and need their own review and testing.
Split this into:
- Theme token swaps (pages only)
ensureArray/useArrayApiQueryAPI hardening (separate PR)
anderdc
left a comment
There was a problem hiding this comment.
API changes split out, pages-only now. CI passes. Looks good.
Summary
palette.alert.warningBg,palette.alert.warningBorder, andpalette.alert.warningTextfor warning alert stylingType of Change