refactor: replace sidebar, FAQ, and selection hardcoded colors with theme tokens#259
Merged
anderdc merged 3 commits intoentrius:testfrom Apr 15, 2026
Merged
Conversation
anderdc
requested changes
Apr 15, 2026
Collaborator
anderdc
left a comment
There was a problem hiding this comment.
- Drop the
sidebarpalette section.#3d3d3dis close enough toborder.medium(rgba(255,255,255,0.2)≈#333), and#888888is close enough totext.secondary(#7d7d7d). Two new palette entries plus TypeScript augmentations for one component's footer isn't worth it — use the existing tokens. - Selection color changed. Original
::selectionbackground was#031cdc, the PR changes it to#1d37fc. Different blue — keep the original or call out the visual change. - Logo drop-shadow conversion is over-engineered. Converting
<img>to<Box component="img">with ansxtheme callback just to resolve a static white glow (rgba(255,255,255,0.8)) isn't worth the added complexity. Leave as-is or usealpha('#ffffff', 0.8)without the component swap.
anderdc
approved these changes
Apr 15, 2026
Collaborator
anderdc
left a comment
There was a problem hiding this comment.
Feedback addressed — sidebar palette dropped, selection color and logo changes removed. Clean swaps using existing tokens. Needs CI to pass before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor removes remaining hardcoded colors from the sidebar and a few shared UI surfaces, replacing them with theme-backed tokens or shared CSS variables.
sidebar.dividerandsidebar.versionTexttosrc/theme.tssrc/components/layout/Sidebar.tsxsrc/components/layout/GlobalSearchBar.tsxunchanged because it already uses theme tokenssrc/components/FAQ.tsxsrc/index.css