Skip to content

refactor: replace sidebar, FAQ, and selection hardcoded colors with theme tokens#259

Merged
anderdc merged 3 commits intoentrius:testfrom
aliworksx08:refactor-sidebar-theme-tokens
Apr 15, 2026
Merged

refactor: replace sidebar, FAQ, and selection hardcoded colors with theme tokens#259
anderdc merged 3 commits intoentrius:testfrom
aliworksx08:refactor-sidebar-theme-tokens

Conversation

@aliworksx08
Copy link
Copy Markdown
Contributor

@aliworksx08 aliworksx08 commented Apr 14, 2026

This refactor removes remaining hardcoded colors from the sidebar and a few shared UI surfaces, replacing them with theme-backed tokens or shared CSS variables.

  • Added sidebar.divider and sidebar.versionText to src/theme.ts
  • Replaced hardcoded colors in src/components/layout/Sidebar.tsx
  • Kept src/components/layout/GlobalSearchBar.tsx unchanged because it already uses theme tokens
  • Replaced hardcoded FAQ border colors with theme border tokens in src/components/FAQ.tsx
  • Replaced hardcoded global text selection colors with shared CSS variables in src/index.css

@aliworksx08 aliworksx08 changed the title refactor: replace sidebar hardcoded colors with theme tokens refactor: replace page hardcoded colors with theme tokens Apr 14, 2026
@aliworksx08 aliworksx08 changed the title refactor: replace page hardcoded colors with theme tokens refactor: replace sidebar hardcoded colors with theme tokens Apr 14, 2026
@aliworksx08 aliworksx08 changed the title refactor: replace sidebar hardcoded colors with theme tokens refactor: replace sidebar, FAQ, and selection hardcoded colors with theme tokens Apr 14, 2026
Copy link
Copy Markdown
Collaborator

@anderdc anderdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Drop the sidebar palette section. #3d3d3d is close enough to border.medium (rgba(255,255,255,0.2)#333), and #888888 is close enough to text.secondary (#7d7d7d). Two new palette entries plus TypeScript augmentations for one component's footer isn't worth it — use the existing tokens.
  • Selection color changed. Original ::selection background was #031cdc, the PR changes it to #1d37fc. Different blue — keep the original or call out the visual change.
  • Logo drop-shadow conversion is over-engineered. Converting <img> to <Box component="img"> with an sx theme callback just to resolve a static white glow (rgba(255,255,255,0.8)) isn't worth the added complexity. Leave as-is or use alpha('#ffffff', 0.8) without the component swap.

@aliworksx08 aliworksx08 requested a review from anderdc April 15, 2026 14:35
Copy link
Copy Markdown
Collaborator

@anderdc anderdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback addressed — sidebar palette dropped, selection color and logo changes removed. Clean swaps using existing tokens. Needs CI to pass before merge.

@anderdc anderdc merged commit 256bb4d into entrius:test Apr 15, 2026
2 checks passed
@aliworksx08 aliworksx08 deleted the refactor-sidebar-theme-tokens branch April 15, 2026 16:09
@anderdc anderdc added the refactor Code restructuring without behavior change label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Code restructuring without behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants