skip extend reservation vote when reservation already expired#36
Open
nudiltoys-cmyk wants to merge 1 commit intoentrius:testfrom
Open
skip extend reservation vote when reservation already expired#36nudiltoys-cmyk wants to merge 1 commit intoentrius:testfrom
nudiltoys-cmyk wants to merge 1 commit intoentrius:testfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
I noticed
_try_extend_reservationfiresvote_extend_reservationeven when the miner's reservation has already lapsed. the conditionreserved_until < current_block + EXTEND_THRESHOLD_BLOCKSis true for anyreserved_untilbehindcurrent_block, so expired reservations trigger a contract call that gets rejected withNoReservationchanged the guard to
0 < blocks_left < EXTEND_THRESHOLD_BLOCKSso it only fires when the reservation is still alive but within the threshold windowtest plan
verified the condition against blocks_left values of -5, 0, 1, 19, 20, 21, only 1 through 19 should trigger the extend vote