fix: use actual fee_divisor in swap receipt instead of hardcoded 100#35
Open
Grizouforever wants to merge 1 commit intoentrius:testfrom
Open
fix: use actual fee_divisor in swap receipt instead of hardcoded 100#35Grizouforever wants to merge 1 commit intoentrius:testfrom
Grizouforever wants to merge 1 commit intoentrius:testfrom
Conversation
_display_receipt hardcodes fee_divisor = 100 while the rest of the swap flow reads it from the contract via get_fee_divisor(). If the on-chain fee changes, the receipt shows incorrect fee amounts. Accept fee_divisor as a parameter with DEFAULT_FEE_DIVISOR fallback, and compute the fee percentage dynamically instead of hardcoding 1%.
Author
|
Hi! This PR is ready for review — all 139/139 tests pass. Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_display_receipthardcodesfee_divisor = 100and displays(1%)while every other function in the swap flow reads the fee divisor from the contract viaget_fee_divisor(). If the on-chain fee changes viaalw admin set-fee-divisor, the receipt shows an incorrect fee amount and percentage.Changes
allways/cli/swap_commands/swap.py:fee_divisorparameter to_display_receipt()withDEFAULT_FEE_DIVISORfallback(1%)fee_divisorfrom the caller where it's already read from the contract