Skip to content

fix: classify testnet P2SH addresses (prefix '2') as P2SH_P2WPKH #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Grizouforever wants to merge 1 commit into
base: test
Choose a base branch
from
+3 −1
Open

fix: classify testnet P2SH addresses (prefix '2') as P2SH_P2WPKH #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion allways/chain_providers/bitcoin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ def detect_address_type(address: str) -> str:
return ADDR_TYPE_P2WPKH
if address.startswith('bcrt1p') or address.startswith('tb1p'):
return ADDR_TYPE_P2TR
if address.startswith('2') or address.startswith('m') or address.startswith('n'):
if address.startswith('2'):
return ADDR_TYPE_P2SH_P2WPKH
if address.startswith('m') or address.startswith('n'):
return ADDR_TYPE_P2PKH
return 'unknown'

Expand Down