Internationalisation implemented; some code clean-up#9
Closed
sm8ps wants to merge 2 commits intoenterprisemediawiki:developmentfrom
sm8ps:master
Closed
Internationalisation implemented; some code clean-up#9sm8ps wants to merge 2 commits intoenterprisemediawiki:developmentfrom sm8ps:master
sm8ps wants to merge 2 commits intoenterprisemediawiki:developmentfrom
sm8ps:master
Conversation
Contributor
|
Sorry for the delay on this. Working several issues on other projects before I can review this further. |
Author
|
No sweat! It is working here, so I am in no hurry. |
Author
|
I just wondered if you had not forgotten about my pull-request. Sorry if this may come inconvenient; I do not mean to push. |
|
This looks like it has already been done separately. Right? Should this be abandoned? |
Contributor
|
@hexmode done separately where? |
|
meh, I had merged his code and lost track of that fact. never mind. |
Contributor
|
Meaning this PR should get merged or should not? |
|
It should be tested first. |
Author
|
Closing as it has probably become obsolete. #26 is an identical try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internationalisation works the way you had suggested. The code works well here with multiple category headers/footers in addition to namespace headers/footers.
While I was at it, I stumbled over https://www.mediawiki.org/wiki/Manual:Messages_API which says to replace calls to deprecated wfMsg-functions. Now I have two changes in this pull request but the second one is easily separated as I left the old commands there as comments.
I noticed that the second function was formatted in a different fashion than the first. So I also changed that.
Cheers!
sm