Fixes duplicated mw-parser-output element#34
Open
vedmaka wants to merge 1 commit intoenterprisemediawiki:masterfrom
Open
Fixes duplicated mw-parser-output element#34vedmaka wants to merge 1 commit intoenterprisemediawiki:masterfrom
mw-parser-output element#34vedmaka wants to merge 1 commit intoenterprisemediawiki:masterfrom
Conversation
Prevent duplicated `mw-parser-output` element from appearing
|
@jamesmontalvo3 bump - would you mind taking a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, both
ParserOutput::getTextandParserOutput::setTextwrap contents returned and set with the default wrapper element which is<div class="mw-parser-output">.This leads to duplicated wrapped
<div class="mw-parser-output">appearing on wiki pages.The patch instructs the first
getTextto omit wrapping via providing awrapperDivClassparameter that effectively removes any wrapping from the markup returned, and the wrapper is added later when contents are set viasetText.