Skip to content

ESB-1012 - Add Web Dynamic Form plugin... #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ffalqui wants to merge 9 commits into
base: develop
Choose a base branch
from
+14,201 −46

ESB-1012 - Fix jpwebdynamicform internal servlet form submission an…

8e5db41
Select commit
Loading
Failed to load commit list.
Open

ESB-1012 - Add Web Dynamic Form plugin... #331

ESB-1012 - Fix jpwebdynamicform internal servlet form submission an…
8e5db41
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 19, 2026 in 2m 59s

Quality Gate failed

Failed conditions
56.7% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 182 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/apsadmin/message/config/NotifierConfigAction.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Throwable. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytMaVeL0hYeMmS4Q&open=AZzhytMaVeL0hYeMmS4Q&pullRequest=331

Check warning on line 292 in webdynamicform-plugin/src/test/java/com/agiletec/plugins/jpwebdynamicform/apsadmin/message/config/NotifierConfigActionTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Immediately return this expression instead of assigning it to the temporary variable "result". 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytRqVeL0hYeMmS9f&open=AZzhytRqVeL0hYeMmS9f&pullRequest=331

Check warning on line 230 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/aps/system/services/message/MessageDAO.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "DELETE_MESSAGE_SEARCH_RECORD" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytMtVeL0hYeMmS4w&open=AZzhytMtVeL0hYeMmS4w&pullRequest=331

Check warning on line 35 in webdynamicform-plugin/src/test/java/com/agiletec/plugins/jpwebdynamicform/aps/system/services/message/renderer/BaseMessageRendererTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytQkVeL0hYeMmS86&open=AZzhytQkVeL0hYeMmS86&pullRequest=331

Check failure on line 125 in engine/src/main/java/org/entando/entando/web/system/SystemController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "appBuilderMenu.hook" 3 times. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytKOVeL0hYeMmS2z&open=AZzhytKOVeL0hYeMmS2z&pullRequest=331

Check warning on line 236 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/aps/system/services/message/MessageDAO.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "DELETE_USERMESSAGES" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytMtVeL0hYeMmS4y&open=AZzhytMtVeL0hYeMmS4y&pullRequest=331

Check warning on line 521 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/apsadmin/message/config/NotifierConfigAction.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_messageManager" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytMaVeL0hYeMmS37&open=AZzhytMaVeL0hYeMmS37&pullRequest=331

Check warning on line 95 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/apsadmin/message/MessageFinderAction.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytL8VeL0hYeMmS29&open=AZzhytL8VeL0hYeMmS29&pullRequest=331

Check warning on line 116 in webdynamicform-plugin/src/test/java/com/agiletec/plugins/jpwebdynamicform/aps/system/services/message/MessageManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytQsVeL0hYeMmS8_&open=AZzhytQsVeL0hYeMmS8_&pullRequest=331

Check warning on line 216 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/aps/system/services/message/MessageManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the type specification in this constructor call with the diamond operator ("<>"). 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytOGVeL0hYeMmS6M&open=AZzhytOGVeL0hYeMmS6M&pullRequest=331

Check warning on line 512 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/apsadmin/message/config/NotifierConfigAction.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the type specification in this constructor call with the diamond operator ("<>"). 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytMaVeL0hYeMmS3s&open=AZzhytMaVeL0hYeMmS3s&pullRequest=331

Check warning on line 175 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/apsadmin/message/MessageFinderAction.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_author" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytL8VeL0hYeMmS3G&open=AZzhytL8VeL0hYeMmS3G&pullRequest=331

Check warning on line 512 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/apsadmin/message/config/NotifierConfigAction.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_recipientsBcc" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytMaVeL0hYeMmS33&open=AZzhytMaVeL0hYeMmS33&pullRequest=331

Check warning on line 134 in webdynamicform-plugin/src/test/java/com/agiletec/plugins/jpwebdynamicform/apsadmin/message/OperatorMessageActionTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytR8VeL0hYeMmS90&open=AZzhytR8VeL0hYeMmS90&pullRequest=331

Check warning on line 128 in webdynamicform-plugin/src/test/java/com/agiletec/plugins/jpwebdynamicform/util/JpwebdynamicformTestHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_messageManager" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytSNVeL0hYeMmS-E&open=AZzhytSNVeL0hYeMmS-E&pullRequest=331

Check warning on line 505 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/apsadmin/message/config/NotifierConfigAction.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_store" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytMaVeL0hYeMmS3x&open=AZzhytMaVeL0hYeMmS3x&pullRequest=331

Check warning on line 218 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/aps/system/services/message/MessageDAO.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "LOAD_MESSAGES_BY_USERNAME" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytMtVeL0hYeMmS4s&open=AZzhytMtVeL0hYeMmS4s&pullRequest=331

Check warning on line 127 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/aps/system/services/message/model/Answer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_text" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytM-VeL0hYeMmS5O&open=AZzhytM-VeL0hYeMmS5O&pullRequest=331

Check warning on line 72 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/aps/internalservlet/message/UserNewMessageAction.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytO5VeL0hYeMmS7k&open=AZzhytO5VeL0hYeMmS7k&pullRequest=331

Check warning on line 41 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/aps/system/services/message/model/MessageModel.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_subjectModel" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytNXVeL0hYeMmS5Y&open=AZzhytNXVeL0hYeMmS5Y&pullRequest=331

Check warning on line 86 in webdynamicform-plugin/src/test/java/com/agiletec/plugins/jpwebdynamicform/aps/ApsPluginBaseTestCase.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytRYVeL0hYeMmS9Z&open=AZzhytRYVeL0hYeMmS9Z&pullRequest=331

Check warning on line 47 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/apsadmin/message/config/NotifierConfigAction.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "isEmpty()" to check whether a "String" is empty or not. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytMaVeL0hYeMmS3_&open=AZzhytMaVeL0hYeMmS3_&pullRequest=331

Check warning on line 117 in webdynamicform-plugin/src/main/java/org/entando/entando/plugins/jpwebdynamicform/aps/system/services/api/ApiMessageInterface.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use isEmpty() to check whether the collection is empty or not. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytP0VeL0hYeMmS8Y&open=AZzhytP0VeL0hYeMmS8Y&pullRequest=331

Check warning on line 241 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/aps/system/services/message/parse/MessageNotifierConfigDOM.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytNyVeL0hYeMmS6A&open=AZzhytNyVeL0hYeMmS6A&pullRequest=331

Check warning on line 84 in webdynamicform-plugin/src/main/java/com/agiletec/plugins/jpwebdynamicform/aps/system/services/message/model/Message.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_creationDate" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=entando_app-engine&issues=AZzhytNIVeL0hYeMmS5R&open=AZzhytNIVeL0hYeMmS5R&pullRequest=331
View more details on SonarQubeCloud