Refactor map_httpcore_exceptions to not be a context manager#3778
Open
akx wants to merge 1 commit intoencode:masterfrom
Open
Refactor map_httpcore_exceptions to not be a context manager#3778akx wants to merge 1 commit intoencode:masterfrom
map_httpcore_exceptions to not be a context manager#3778akx wants to merge 1 commit intoencode:masterfrom
Conversation
`contextlib.contextmanager`s are much slower than `try:except:`, and here they occur in very hot paths. Sibling of encode/httpcore#1044
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contextlib.contextmanagers are much slower thantry:except:(where the no-except path is free in new Pythons), and here they occur in very hot paths.Sibling of encode/httpcore#1044.
This benchmarks to be slightly faster than the original, like in the
httpcoresibling PR:where
test_bench1isChecklist
pragma: no covers were added to the exception branches that were actually not covered originally either.map_httpcore_exceptions()was meant to be a public API.)