NXT-10274: Added logic to not add pending failing ss-tests to failedTests.html#179
Merged
NXT-10274: Added logic to not add pending failing ss-tests to failedTests.html#179
Conversation
ion-andrusciac-lgp
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Jenkins job for screenshot tests shows 1 failed tests, but also 2 other tests that passed after a retry.
FailedTests.html shows 3 entries, 2 of them having a broken "diff". But there are no diffs on the server because those 2 tests passed.
Resolution
The solution is to track pending failed tests and to log the entry to
failedScreenshotFilenameonly if all retries have failed. The entry will be added only at the completion of the testsAdditional Considerations
pendingKey was added to overcome possible invalid filename characters and path length limits
Links
NXT-10274
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)