Skip to content

feat(ld-file-upload): add file upload component#861

Draft
leabarth wants to merge 42 commits intomainfrom
feat/ld-file-upload
Draft

feat(ld-file-upload): add file upload component#861
leabarth wants to merge 42 commits intomainfrom
feat/ld-file-upload

Conversation

@leabarth
Copy link
Copy Markdown
Contributor

@leabarth leabarth commented Jul 28, 2023

Description

Fixes #(issue)

Type of change

  • Feature

Is it a breaking change?

  • Yes
  • No

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquid ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 7:52pm

Comment thread src/liquid/components/ld-file-upload/ld-choose-file/files.svg Outdated
Comment thread src/liquid/components/ld-file-upload/ld-choose-file/ld-choose-file.css Outdated
Comment thread src/liquid/components/ld-file-upload/ld-choose-file/ld-choose-file.css Outdated
Comment thread src/liquid/components/ld-file-upload/ld-choose-file/ld-choose-file.css Outdated
Comment thread src/liquid/components/ld-file-upload/ld-choose-file/ld-choose-file.css Outdated
Comment thread src/liquid/components/ld-file-upload/ld-file-upload.tsx Outdated
Comment thread src/liquid/components/ld-file-upload/ld-file-upload.tsx Outdated
Comment thread src/liquid/components/ld-file-upload/ld-file-upload.tsx Outdated
Comment thread src/liquid/components/ld-file-upload/ld-file-upload.tsx Outdated
this.cannotBeChosen = []
this.exceedMaxSize = []
for (let i = 0; i < chosenFiles.length; i++) {
if (
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use a Set or a Map here in order to improve performance and readability.

Comment thread src/liquid/components/ld-file-upload/ld-choose-file/ld-choose-file.tsx Outdated
Comment thread src/liquid/components/ld-file-upload/ld-choose-file/ld-choose-file.tsx Outdated
Comment thread src/liquid/components/ld-file-upload/ld-choose-file/ld-choose-file.tsx Outdated
Comment thread src/liquid/components/ld-file-upload/ld-choose-file/ld-choose-file.tsx Outdated
Comment thread src/liquid/components/ld-file-upload/ld-choose-file/ld-choose-file.tsx Outdated
Comment thread src/liquid/components/ld-file-upload/ld-choose-file/ld-choose-file.tsx Outdated
Comment thread src/liquid/components/ld-file-upload/ld-choose-file/ld-choose-file.tsx Outdated
Comment thread src/liquid/components/ld-file-upload/ld-choose-file/ld-choose-file.tsx Outdated
Comment thread src/liquid/components/ld-file-upload/ld-choose-file/ld-choose-file.tsx Outdated
Comment thread src/liquid/components/ld-file-upload/ld-choose-file/ld-choose-file.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants