[WIP] Add prose to the proposal for moving blueprints off the release train#1172
Conversation
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
text/1160-no-more-release-train.md
Outdated
|
|
||
| If the user specifies a specific blueprint version: | ||
|
|
||
| - `ember new my-app --blueprints-version=1.2.3` |
There was a problem hiding this comment.
@copilot we don't want this extra flag, I think we can already do --blueprint @blueprint/name@version
There was a problem hiding this comment.
Updated in 1371c47 — removed the custom --blueprints-version flag and the prose now references the existing --blueprint @blueprint/name@version mechanism instead.
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
text/1160-no-more-release-train.md
Outdated
| - Blueprint packages ship continuously from `main`. | ||
| - `ember-cli` defaults to a known-good, pinned blueprint version. | ||
| - Users may choose the latest blueprint version at generation time. | ||
| - Users may specify any specific blueprint version at generation time via `--blueprint @blueprint/name@version` (e.g. for testing). |
There was a problem hiding this comment.
@copilot we also want the interactive side of this to work as well. while --blueprint is how we want users to generate specific things in a non-interactive way, the interactive mode should provide a version selection UI for the selected blueprint
There was a problem hiding this comment.
Done in f76a2ae. The interactive prompt now includes a third option — "Choose a specific version" — which triggers a secondary version selection UI (a list of recent published versions fetched from the registry). The non-interactive path continues to use --blueprint @blueprint/name@version. Both are documented in the updated "Specifying a specific blueprint version" subsection.
…rose Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
| - Blueprint packages ship continuously from `main`. | ||
| - `ember-cli` defaults to a known-good, pinned blueprint version. | ||
| - Users may choose the latest blueprint version at generation time. | ||
| - Users may specify any specific blueprint version at generation time—interactively via a version selection UI, or non-interactively via `--blueprint @blueprint/name@version` (e.g. for testing). |
There was a problem hiding this comment.
@copilot add that this is contingent on out-of-scope work for making blueprint generation in general interactive
There was a problem hiding this comment.
Done in ef10415. Added a blockquote note directly after the interactive mode description clarifying that the version selection UI is contingent on out-of-scope work to make blueprint generation generally interactive, and that this prerequisite work is not defined by this RFC.
…ope work Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Stacked on #1160. Adds prose requested in this review comment about allowing users to select any specific blueprint version at generation time—not just "bundled" or "latest"—via both an interactive version selection UI and the existing
--blueprint @blueprint/name@versionmechanism.Propose No Release Train for Blueprints
Rendered
Summary
This pull request is proposing a new RFC.
To succeed, it will need to pass into the Exploring Stage, followed by the Accepted Stage.
A Proposed or Exploring RFC may also move to the Closed Stage if it is withdrawn by the author or if it is rejected by the Ember team. This requires an "FCP to Close" period.
An FCP is required before merging this PR to advance to Accepted.
Upon merging this PR, automation will open a draft PR for this RFC to move to the Ready for Released Stage.
Changes in this PR
--blueprint @blueprint/name@version(e.g. for testing)--blueprint @blueprint/name@version) approaches, covering use cases: pre-bundled testing, debugging/reproducing output, downgrading for comparison; notes that the interactive version selection UI is contingent on out-of-scope work to make blueprint generation generally interactiveember new my-app --blueprint @ember/app-blueprint@1.2.3(non-interactive, skips prompt)--blueprint @blueprint/name@version(the existing mechanism) can be used in automation to pin a specific versionChecklist to move to Exploring
S-Proposedis removed from the PR and the labelS-Exploringis added.Checklist to move to Accepted
Final Comment Periodlabel has been added to start the FCP🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.