Merged
Conversation
|
alexheifetz
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
@DependsOnrequirement when directly injecting model beans (EmbeddingService,LlmService) registered viaregisterSingletonProviderInitializationKDoc to explain the dynamic registration pattern and its implications for consumers@DependsOnin theDrivineStorecode examples (Java and Kotlin)Context
Model provider auto-configurations register beans dynamically via
ConfigurableBeanFactory.registerSingleton()to support multiple models per provider with configuration-driven names. This is invisible to most consumers since framework beans likeModelProviderhandle ordering internally.However, application code that injects
EmbeddingServiceorLlmServicedirectly (e.g. wiring a customDrivineStore) will get aNoSuchBeanDefinitionExceptionwithout@DependsOn, because Spring resolves the dependency before the initializer's factory method has run.Discovered while integrating the ONNX embedding module in embabel/guide.
Changes
embabel-agent-common/embabel-agent-ai/.../ProviderInitialization.ktregisterSingletonpattern, when@DependsOnis needed, and whyembabel-agent-docs/.../reference/rag/page.adoc@DependsOn("onnxEmbeddingInitializer")to Java and Kotlin examples; added NOTE explaining the requirement