Skip to content

Fix CI#134

Merged
lydell merged 7 commits intomainfrom
fix-ci
Dec 29, 2025
Merged

Fix CI#134
lydell merged 7 commits intomainfrom
fix-ci

Conversation

@lydell
Copy link
Copy Markdown
Member

@lydell lydell commented Dec 29, 2025

No description provided.

@lydell lydell merged commit cde9031 into main Dec 29, 2025
22 checks passed
Copy link
Copy Markdown
Contributor

@lishaduck lishaduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for saving me from myself @lydell! :P

Comment on lines +65 to +66
# `--no-audit` is used because nobody looks at audit reports in CI –
# it’s just a waste of time.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clever, I'll be using this trick in the future. Thanks for the inspiration!

Comment on lines +67 to +68
# Newer versions of actions/setup-node has a caching option built in,
# but in my experience it is always slower than setting up the cache yourself.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, the reason the setup-node cache is slow is because it's not actually caching node_modules: it's caching the npm/yarn/pnpm cache but you still need to run install, so yeah, doing it manually should still be ∞ faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants