feat: Allow setting beginning of week as Sunday in calendar#1010
Draft
Duckiduc wants to merge 1 commit intoellite:mainfrom
Draft
feat: Allow setting beginning of week as Sunday in calendar#1010Duckiduc wants to merge 1 commit intoellite:mainfrom
Duckiduc wants to merge 1 commit intoellite:mainfrom
Conversation
- Implemented a new endpoint to update the week_starts_sunday setting. - Modified the settings retrieval to include week_starts_sunday. - Added translation for the week_starts_sunday label. - Updated user creation to include week_starts_sunday in the settings. - Created a migration to add week_starts_sunday column to the settings table. - Updated registration and settings scripts to handle week_starts_sunday. - Added a checkbox in the settings UI for users to set their preference for the week starting on Sunday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a user setting to start the calendar week on Sunday instead of Monday.
Changes
migrations/000045.php): Addsweek_starts_sundayboolean column to thesettingstable, defaulting to0(Monday-first) for all existing users.settings.php): Adds a checkbox under Display Settings → Experience to toggle the preference.endpoints/settings/week_starts_sunday.php): Persists the preference to the database.calendar.php): Rotates the weekday header and leading empty cells based on the saved preference.includes/i18n/en.php): Adds theweek_starts_on_sundaytranslation key.registration.php,endpoints/admin/adduser.php,includes/oidc/oidc_create_user.php): Includes the new column in allINSERT INTO settingsstatements.includes/getsettings.php): Normalises the value with a safe fallback for rows that predate the migration.Behaviour
Testing
week_starts_sundaycolumn is added.Closes #1001