Open
Conversation
mkaput
force-pushed
the
pr/parse-assertions-unify
branch
2 times, most recently
from
33cf582 to
a7d61db
Compare
mhanberg
changed the title
I have noticed a proliferation of various ways how to assert Spitfire conformance with Elixir parser. This commit introduces uniform assertion macros library, so we: 1. have a single place to modify, 2. have a single format of assertion messages, 3. and significantly reduce LOC in test files.
mkaput
force-pushed
the
pr/parse-assertions-unify
branch
from
a7d61db to
622e514
Compare
Replace remaining manual parse-vs-quoted assertions in regression cases with assert_conforms/1, and convert the fn-delimiter error regression checks to assert_errors/1. This keeps spitfire_test aligned with the shared Spitfire.Assertions helpers and reduces duplicated assertion boilerplate. Manual testing: - mix format - mix test (property-test failures in Spitfire.CharPropertyTest are known)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed a proliferation of various ways how to assert Spitfire conformance with Elixir parser. This PR introduces uniform assertion macros library, so we:
Please review commit-by-commit.