Conversation
dsanders11
approved these changes
Apr 8, 2026
| import HtmlWebpackPlugin from 'html-webpack-plugin'; | ||
| import * as webpack from 'webpack'; | ||
| import { DefinePlugin, ExternalsPlugin, WebpackPluginInstance } from 'webpack'; | ||
| import type * as webpack from 'webpack'; |
Member
There was a problem hiding this comment.
nit(non-blocking): since we only need WebpackPluginInstance, could this just be import type { WebpackPluginInstance } from 'webpack';?
Member
Author
There was a problem hiding this comment.
This isn't in the diff but there are a handful of other types we were using beforehand (Configuration, Entry, etc.)
Member
Author
|
Need a re-approval. Added 9f0e1a0 because of an oversight (can't use the same code path to |
dsanders11
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESM interop fails us at times when consuming CommonJS modules. This upstreams a patch from electron/fiddle#1878 and adds a regression test to
test-dist.tsto ensure that all modules without side effects are importable.