Skip to content

build: remove unused monaco features #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsanders11 merged 5 commits into from
Nov 19, 2025
Merged

build: remove unused monaco features #1813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0d9794
build: remove unused monaco features
erickzhao Nov 18, 2025
8e53d56
add more things, remove command palette
erickzhao Nov 18, 2025
b03aa1f
Merge branch 'main' into slim-down-monaco-build
erickzhao Nov 18, 2025
1c7e8a2
zzz
erickzhao Nov 18, 2025
6d676e6
Merge branch 'slim-down-monaco-build' of github.com:electron/fiddle i…
erickzhao Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/main/context-menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,6 @@ export function getMonacoItems({
},
},
{ type: 'separator' },
{
id: 'palette',
label: 'Command Palette',
click() {
const cmd = ['editor.action.quickCommand'];
ipcMainManager.send(IpcEvents.MONACO_EXECUTE_COMMAND, cmd);
},
},
{ type: 'separator' },
{
id: 'format_document',
label: 'Format Document',
Expand Down
2 changes: 1 addition & 1 deletion tests/main/context-menu-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ describe('context-menu', () => {
editFlags: { canPaste: true },
pageURL: 'index.html',
} as any);
expect(result).toHaveLength(10);
expect(result).toHaveLength(8);
});

it('executes an IPC send() for each element', () => {
Expand Down
9 changes: 9 additions & 0 deletions tools/webpack/webpack.renderer.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,15 @@ export const rendererConfig: Configuration = {
...plugins,
new MonacoWebpackPlugin({
languages: ['typescript', 'javascript', 'html', 'css'],
// This array maps to specific entries in the Monaco metadata
// To see a full list and where they map to in VSCode, see 'monaco-editor/esm/metadata'
features: [
'!contextmenu',
'!iPadShowKeyboard',
'!snippets',
'!quickCommand',
'!quickOutline',
],
}),
new MiniCssExtractPlugin({
filename: './css/[name].css',
Expand Down