Skip to content

refactor: run ensurePrereqs for all e commands #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkleinsc merged 1 commit into from
Apr 8, 2026
Merged

refactor: run ensurePrereqs for all e commands #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/e-sync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { ensureDir } from './utils/paths.js';
import * as depot from './utils/depot-tools.js';
import { configureReclient } from './utils/setup-reclient-chromium.js';
import { ensureSDK } from './utils/sdk.js';
import { ensurePrereqs } from './utils/prereqs.js';
import type { ElectronRemotes } from './types.js';

function setRemotes(cwd: string, repo: ElectronRemotes): void {
Expand Down Expand Up @@ -49,8 +48,6 @@ function setRemotes(cwd: string, repo: ElectronRemotes): void {
}

function runGClientSync(syncArgs: string[], syncOpts: { threeWay?: boolean }): void {
ensurePrereqs();

const config = evmConfig.current();
const srcdir = path.resolve(config.root, 'src');
ensureDir(srcdir);
Expand Down
4 changes: 4 additions & 0 deletions src/e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,16 @@ import { program } from 'commander';
import * as evmConfig from './evm-config.js';
import { color, fatal } from './utils/logging.js';
import * as depot from './utils/depot-tools.js';
import { ensurePrereqs } from './utils/prereqs.js';
import { refreshPathVariable } from './utils/refresh-path.js';
import { ensureSDK } from './utils/sdk.js';

// Refresh the PATH variable at the top of this shell so that retries in the same shell get the latest PATH variable
refreshPathVariable();

// Fail fast on unsupported Node.js / Python runtimes before doing any work.
ensurePrereqs();

function maybeCheckForUpdates(): void {
// skip auto-update check if disabled
//
Expand Down