Open
Conversation
|
+1 |
There is a completely identical test just above
090f898 to
25c2c18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transferred from elastic/elasticsearch-ruby#1083, original PR by @eliskah
Original Pull Request message
This PR should fix following:
When using field collapsing, it is possible to define
_sourcefor inner hits, like this:{ "collapse": { "field" : "user_id", "inner_hits" : { "name" : "records", "size" : 5, "_source" : ["content", "updated_at"] } }, "_source" : false, "size" : 10 }DSL supports collapsing with inner hits fine, but if I try to define the
_sourceinside theinner_hitsblock, it's used in the top level_sourceinstead. See this example:Returns:
{ "size": 10, "collapse": { "field": "user_id", "inner_hits": { "name": "records", "size": 5 } }, "_source": [ "content", "updated_at" ] }I would expect to get the query as above: With top level
_sourcevalue offalseand inner hits level_sourcewith the fields"content"and"updated_at".