elasticapm/utils: match the specs better in build_name_with_http_meth…#2605
Draft
xrmx wants to merge 1 commit intoelastic:mainfrom
Draft
elasticapm/utils: match the specs better in build_name_with_http_meth…#2605xrmx wants to merge 1 commit intoelastic:mainfrom
xrmx wants to merge 1 commit intoelastic:mainfrom
Conversation
…od_prefix In case the route name is not available we should use `unknown route` as route name. While at it handle the case where the request does not have a method attribute. Mostly theorical since the current users, flask and django, requests have it. Specs: https://github.com/elastic/apm/blob/main/specs/agents/tracing-instrumentation-http.md
🤖 GitHub commentsJust comment with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…od_prefix
In case the route name is not available we should use
unknown routeas route name.While at it handle the case where the request does not have a method attribute. Mostly theorical since the current users, flask and django, requests have it.
Specs:
https://github.com/elastic/apm/blob/main/specs/agents/tracing-instrumentation-http.md
What does this pull request do?
Related issues
Closes #ISSUE