Skip to content

Fix span ID collisions: use random_bytes() instead of mt_rand() #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
githoober wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix span ID collisions: use random_bytes() instead of mt_rand() #1444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 1 addition & 29 deletions agent/php/ElasticApm/Impl/Util/IdGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,34 +37,6 @@ final class IdGenerator

public static function generateId(int $idLengthInBytes): string
{
return self::convertBinaryIdToString(self::generateBinaryId($idLengthInBytes));
}

/**
* @param array<int> $binaryId
*
* @return string
*/
private static function convertBinaryIdToString(array $binaryId): string
{
$result = '';
for ($i = 0; $i < count($binaryId); ++$i) {
$result .= sprintf('%02x', $binaryId[$i]);
}
return $result;
}

/**
* @param int $idLengthInBytes
*
* @return array<int>
*/
private static function generateBinaryId(int $idLengthInBytes): array
{
$result = [];
for ($i = 0; $i < $idLengthInBytes; ++$i) {
$result[] = mt_rand(0, 255);
}
return $result;
return bin2hex(random_bytes($idLengthInBytes));
}
}
Loading