feat: accept repository input parameter for CVMFS repository#31
Open
wdconinc wants to merge 1 commit into
Open
feat: accept repository input parameter for CVMFS repository#31wdconinc wants to merge 1 commit into
repository input parameter for CVMFS repository#31wdconinc wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a configurable repository input parameter to allow users to specify which CVMFS repository to use, replacing the previously hardcoded singularity.opensciencegrid.org repository.
Changes:
- Added
repositoryinput parameter with default valuesingularity.opensciencegrid.orgto maintain backward compatibility - Updated shell script to use the configurable repository path instead of hardcoded values
- Added documentation for the new parameter
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| action.yml | Adds the repository input parameter definition and maps it to the EIC_SHELL_REPOSITORY environment variable |
| run-linux.sh | Replaces hardcoded repository paths with the EIC_SHELL_REPOSITORY variable in CVMFS mount checks and sandbox path construction |
| README.md | Documents the new repository parameter in the parameters list |
| .github/workflows/organization.yml | Updates the test workflow to explicitly specify the repository parameter, serving as a usage example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR adds the
repositoryinput parameter to set the CVMFS repository to use.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.