Add transparent Docker fallback when CVMFS sandbox not found#30
Add transparent Docker fallback when CVMFS sandbox not found#30Copilot wants to merge 9 commits into
Conversation
|
@copilot Add explicit tests for the docker fall through functionality. |
Added comprehensive test workflow in commit 0281436. The workflow includes:
The workflow supports both automatic testing (on PR/push for detection logic) and manual testing (workflow_dispatch with custom Docker images that exist on ghcr.io). |
There was a problem hiding this comment.
Pull request overview
This PR adds transparent Docker fallback functionality that automatically uses Docker containers from ghcr.io when the requested container image is not found on CVMFS. This enables testing of containers that haven't been published to CVMFS yet without requiring workflow changes.
Changes:
- Modified
run-linux.shto detect when CVMFS sandbox path doesn't exist and fall back to Docker - Added Docker container management logic with persistent containers and error handling
- Updated documentation to explain the Docker fallback feature
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| run-linux.sh | Implements Docker fallback detection, container creation/reuse logic, and payload execution in Docker containers when CVMFS path is not found |
| README.md | Documents the new Docker fallback feature, its capabilities, and how it works |
| .github/workflows/docker-fallback.yml | Adds comprehensive tests for Docker fallback functionality including detection and container reuse |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
- Use ghcr.io/eic/eic_cvmfs:nightly as test image (exists on ghcr.io but not CVMFS) - Remove workflow_dispatch restriction from reuse test - Run tests on all branches (remove copilot/** restriction) - Mount /cvmfs in Docker containers for consistency with Apptainer - Remove redundant CVMFS unchanged test (covered by other workflows) Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
…iables - Remove diagnostic message step that prints check instructions - Use handlebar variables instead of hard-coded image name in echo statement Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
d7d51ce to
323e4b7
Compare
Summary
Updated Docker fallback implementation based on code review feedback.
Completed Tasks
run-linux.shto detect when CVMFS path doesn't existLatest Changes
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.