Skip to content

Move Python launcher files from src/dd4pod/python to src/python#56

Open
Copilot wants to merge 1 commit into
mainfrom
copilot/move-src-dd4pod-to-src-python
Open

Move Python launcher files from src/dd4pod/python to src/python#56
Copilot wants to merge 1 commit into
mainfrom
copilot/move-src-dd4pod-to-src-python

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 18, 2026

Summary

  • move the Python launcher files to src/python for clearer ownership
  • update top-level CMake to include src/python instead of src/dd4pod
  • keep install behavior unchanged for npsim and npsim.py

Validation

  • cmake -S . -B build && cmake --build build && ctest --test-dir build --output-on-failure (fails in this environment due to missing DD4hepConfig.cmake/DD4hep 1.18)
  • CodeQL checker: 0 alerts

Agent-Logs-Url: https://github.com/eic/npsim/sessions/b9ea9b1a-e9d4-4178-9eea-9068f4305d30

Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot AI requested a review from wdconinc May 18, 2026 00:19
@wdconinc wdconinc marked this pull request as ready for review May 18, 2026 00:25
Copilot AI review requested due to automatic review settings May 18, 2026 00:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR relocates the npsim Python launcher files into src/python and updates CMake to install them from the new location.

Changes:

  • Adds src/python/npsim.py and src/python/npsim.in.
  • Updates src/python/CMakeLists.txt to reference files in its own directory.
  • Updates the top-level build to add src/python instead of src/dd4pod.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
CMakeLists.txt Switches the launcher subdirectory included by the top-level build.
src/python/CMakeLists.txt Installs the wrapper and Python launcher from the relocated directory.
src/python/npsim.in Defines the installed shell wrapper for npsim.
src/python/npsim.py Provides the DD4hep simulation launcher logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc requested review from a team and veprbl May 18, 2026 00:31
Copilot AI temporarily deployed to github-pages May 18, 2026 00:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants