Move Python launcher files from src/dd4pod/python to src/python#56
Open
Copilot wants to merge 1 commit into
Open
Move Python launcher files from src/dd4pod/python to src/python#56Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Agent-Logs-Url: https://github.com/eic/npsim/sessions/b9ea9b1a-e9d4-4178-9eea-9068f4305d30 Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
wdconinc
May 18, 2026 00:19
View session
wdconinc
approved these changes
May 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR relocates the npsim Python launcher files into src/python and updates CMake to install them from the new location.
Changes:
- Adds
src/python/npsim.pyandsrc/python/npsim.in. - Updates
src/python/CMakeLists.txtto reference files in its own directory. - Updates the top-level build to add
src/pythoninstead ofsrc/dd4pod.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
CMakeLists.txt |
Switches the launcher subdirectory included by the top-level build. |
src/python/CMakeLists.txt |
Installs the wrapper and Python launcher from the relocated directory. |
src/python/npsim.in |
Defines the installed shell wrapper for npsim. |
src/python/npsim.py |
Provides the DD4hep simulation launcher logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Capybara summary for PR 56
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/pythonfor clearer ownershipsrc/pythoninstead ofsrc/dd4podnpsimandnpsim.pyValidation
cmake -S . -B build && cmake --build build && ctest --test-dir build --output-on-failure(fails in this environment due to missingDD4hepConfig.cmake/DD4hep 1.18)