feat: add unit/integration tests for tools and geocad and run them in linux-eic-shell CI

[Copilot]

Summary

Adds unit and integration tests for the npdet_to_step geometry tool and the GeoCad library, and wires them into the linux-eic-shell CI workflow.

Changes

CI (.github/workflows/linux-eic-shell.yml)

• Enable -DUSE_GEOCAD=ON in the cmake configure step so the geocad library and its tests are built
• Run ctest in the build matrix before installing, with --output-on-failure and --no-tests=error

Build system

• Move include(CTest) to the top-level CMakeLists.txt (required for add_test to work correctly)
• Wire test subdirectories into the geocad and tools CMake builds

npdet_to_step tool (src/tools/)

• Extract CLI argument parsing from npdet_to_step.cxx into npdet_to_step_cli.cxx / npdet_to_step_cli.h to separate main() from the parsing logic
• Unit test for settings helpers (unit_settings.cxx): verifies ensure_step_extension handles various filename inputs
• Integration tests:
  • tools_integration_npdet_to_step_help: verifies the help subcommand prints the expected description
  • tools_integration_npdet_to_step_missing_input: verifies an appropriate error message is printed when a non-existent compact file is supplied (uses PASS_REGULAR_EXPRESSION rather than WILL_FAIL to avoid the CTest property-inversion issue when combining those two properties)

GeoCad library (src/geocad/)

• Unit test for partial-tree extraction (unit_partial_tree.cxx)
• Integration test for STEP file creation from a synthetic TGeo geometry (integration_create_step.cxx)

[wdconinc]

@copilot Wire the testing into the linux-eic-shell CI workflow as part of the build job matrix. DD4hep and OpenCascade will be available (enable GEOCAD build option if not already enabled).

[Copilot]

@copilot Wire the testing into the linux-eic-shell CI workflow as part of the build job matrix. DD4hep and OpenCascade will be available (enable GEOCAD build option if not already enabled).

Updated in 8a92bb9: the linux-eic-shell build matrix job now configures CMake with -DUSE_GEOCAD=ON, builds, runs ctest --test-dir build --output-on-failure --no-tests=error, and then installs.

[github-actions]

Capybara summary for PR 52

• sim_dis_10x100_minQ2=1000_epic_craterlake
• sim_dis_10x100_minQ2=1_epic_craterlake
• sim_dis_18x275_minQ2=1000_epic_craterlake
• sim_dis_18x275_minQ2=1_epic_craterlake
• sim_dis_5x41_minQ2=1_epic_craterlake
• sim_e_1GeV_20GeV_epic_craterlake
• sim_pi_1GeV_20GeV_epic_craterlake
  ^{_{Last updated 2026-05-17T20:04-04:00 eeafeec}}

[Copilot]

Pull request overview

Adds unit and integration tests for the npdet_to_step CLI tool and the GeoCad library, refactors npdet_to_step.cxx to separate CLI parsing into its own translation unit, and wires the new tests into the linux-eic-shell CI workflow (with -DUSE_GEOCAD=ON and a ctest step).

Changes:

• Refactor: split argument parsing out of npdet_to_step.cxx into npdet_to_step_cli.{h,cxx} and move the .stp-suffix helper into settings.h as ensure_step_extension.
• New tests: unit_settings, tools_integration_npdet_to_step_help/_missing_input for tools; unit_partial_tree and integration_create_step for geocad.
• Build/CI: hoist include(CTest) to top-level CMake, wire tests/ subdirectories under BUILD_TESTING, enable USE_GEOCAD and run ctest in the eic-shell workflow.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
CMakeLists.txt	Add top-level include(CTest) to enable testing globally.
.github/workflows/linux-eic-shell.yml	Configure with -DUSE_GEOCAD=ON, build, then run ctest before install.
src/tools/CMakeLists.txt	Add npdet_to_step_cli.cxx to executable and add tests subdir under BUILD_TESTING.
src/tools/src/npdet_to_step.cxx	Slim main(); delegate parsing to cmdline_settings and use new ensure_step_extension helper.
src/tools/src/npdet_to_step_cli.{h,cxx}	New TU containing CLI parsing/help-page logic extracted from npdet_to_step.cxx.
src/tools/src/settings.h	Add inline ensure_step_extension helper for .stp suffix handling.
src/tools/tests/CMakeLists.txt	Replace simple Catch test with unit_settings and two npdet_to_step integration tests using PASS_REGULAR_EXPRESSION.
src/tools/tests/unit_settings.cxx	Unit test for ensure_step_extension covering several filename shapes.
src/tools/tests/simple.cxx	Remove obsolete Catch-based placeholder test.
src/geocad/CMakeLists.txt	Add tests subdir under BUILD_TESTING.
src/geocad/tests/CMakeLists.txt	Define unit/integration test executables linked against GeoCad and register add_test.
src/geocad/tests/unit_partial_tree.cxx	Exercise TOCCToStep::OCCPartialTreeCreation on a synthetic TGeo tree.
src/geocad/tests/integration_create_step.cxx	Build a synthetic TGeo geometry, run TGeoToStep::CreateGeometry, and verify a non-empty .stp file.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.