Draft
Conversation
github-actions
Bot
added
topic: barrel
wdconinc
force-pushed
the
parametrized-volumes
branch
from
af6aa53 to
3bcf1e6
Compare
wdconinc
commented
Apr 29, 2026
Contributor
Author
wdconinc
left a comment
wdconinc
left a comment
There was a problem hiding this comment.
For BIC, i_module is now identical to i_y.
Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
for more information, see https://pre-commit.ci
Contributor
Capybara summary for PR 1051
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR converts loops of placement to parametrized placement in the BIC and FEMC. This may result in faster geant4 navigation in these detectors.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.