Merged
Conversation
Copilot
AI
changed the title
[WIP] Add covfie as a dependency to epic package
Add covfie dependency to epic @26.03.0:
Feb 26, 2026
wdconinc
reviewed
Feb 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the covfie dependency to the epic Spack package for versions 26.03.0 and later, as epic now requires this library starting from that version.
Changes:
- Added
covfieas a dependency forepic@26.03.0:to match the requirement introduced in that version
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
changed the title
9 tasks
wdconinc
changed the title
wdconinc
changed the title
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
wdconinc
force-pushed
the
copilot/add-covfie-dependency-to-epic
branch
from
937bf6e to
ab5f3bd
Compare
Contributor
|
RFR Rescoped to only apply to main (and we'll change when there's a release which actually needs covfie). |
Contributor
|
@eic/epic-review-team This PR has been languishing for nearly 2 months now and holds up testing of eic/epic#934 which is needed for both celeritas and adept development. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
epicrequirescovfiestarting from version 26.04, includingmain.covfieis available in the upstream spack builtin repository.Needed for eic/epic#934.
Changes
epicpackage: addsdepends_on("covfie", when="@26.04.0:"), mirroring the existingirt2constraint for the same version range.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.