Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the EICrecon reconstruction framework from version 1.34.0 to 1.35.0, in line with the upstream release at https://github.com/eic/EICrecon/releases/tag/v1.35.0. The EICSPACK_VERSION commit hash is also advanced to the eic-spack repository state that contains the new package definition.
Changes:
- Bump eicrecon version constraint from
@1.34.0to@1.35.0inpackages.yaml. - Advance
EICSPACK_VERSIONto commit753bf382eceee9d22205fd25a57d1c660b2e1099ineic-spack.shto include the eicrecon 1.35.0 package recipe.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
spack-environment/packages.yaml |
Updates the Spack version constraint for eicrecon to @1.35.0 |
eic-spack.sh |
Updates the eic-spack repository commit hash to one that provides the eicrecon 1.35.0 package definition |
wdconinc
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/eic/EICrecon/releases/tag/v1.35.0