Conversation
Contributor
|
This PR intends to solve incorrect (early) job instantiations in e.g. https://eicweb.phy.anl.gov/containers/eic_container/-/jobs/7378982. |
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix syntax in needs sections of .gitlab-ci.yml
fix(ci): correct Mar 5, 2026
needs: parallel: matrix: syntax for downstream job dependencies
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes GitLab CI needs: dependencies on specific parallel:matrix job instances so downstream jobs correctly wait for the exact container image build they require (instead of running immediately due to unresolved dependencies).
Changes:
- Updates 6
needs: parallel: matrix:blocks in.gitlab-ci.ymlto use scalar values forENVandBUILD_TYPE(e.g.,ENV: ci), matching GitLab’s expected syntax for targeting a single matrix-expanded job. - Keeps the full matrix key set (e.g.,
BUILDER_IMAGE,RUNTIME_IMAGE,PLATFORM) to uniquely identify the intended upstream build instance.
wdconinc
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitLab CI
needs:referencing a specific parallel matrix job instance requires scalar values — using YAML list notation causes GitLab to fail resolving the dependency, so downstream jobs run immediately without waiting for their required container images.Changes
.gitlab-ci.ymlhadENVandBUILD_TYPEchanged from list to scalar syntax in theirneeds: parallel: matrix:blocks:user_spack_environment(needseic_ci, default).cuda(needseic_dev_cuda, default)eic_xl:singularity:default/eic_xl:singularity:nightly.benchmarks:default/.benchmarks:nightlyBefore:
After:
Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.