Skip to content

feat: Add outdated eic-shell warning for singularity/apptainer users#180

Open
Copilot wants to merge 5 commits intomasterfrom
copilot/add-warning-for-singularity-users
Open

feat: Add outdated eic-shell warning for singularity/apptainer users#180
Copilot wants to merge 5 commits intomasterfrom
copilot/add-warning-for-singularity-users

Conversation

Copy link
Contributor

Copilot AI commented Mar 4, 2026

Users running inside singularity/apptainer have no way to know their outer eic-shell script is stale—there's no automatic update mechanism once it's installed. Add a startup warning when the script can be upgraded.

Changes

  • New containers/eic/profile.d/z15_singularity_update.sh: sourced at shell startup; warns when all of the following hold:
    • Shell is interactive
    • Running inside singularity/apptainer ($SINGULARITY_CONTAINER or $APPTAINER_CONTAINER is set)
    • $EIC_SHELL_PREFIX/../eic-shell exists and is writable by the current user
    • That script's mtime is older than 180 days

When triggered, the warning suggests:

WARNING: Your eic-shell script appears to be more than 6 months old.
         Consider upgrading by running outside the container:
           eic-shell --upgrade

The write-access check gates the warning—if the user can't upgrade, there's no point in warning them.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…cript

Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot AI changed the title [WIP] Add warning for users running singularity/apptainer Add outdated eic-shell warning for singularity/apptainer users Mar 4, 2026
@wdconinc wdconinc marked this pull request as ready for review March 4, 2026 14:22
Copilot AI review requested due to automatic review settings March 4, 2026 14:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a shell-startup warning inside Singularity/Apptainer containers to help users notice when their outer eic-shell launcher script is likely stale and upgradable.

Changes:

  • Introduces a new profile.d startup script that conditionally warns on interactive shells inside Singularity/Apptainer.
  • Detects an upgradable outer eic-shell script (exists, writable) and checks whether its mtime is older than ~180 days.
  • Prints guidance to run eic-shell --upgrade outside the container when triggered.

wdconinc and others added 2 commits March 4, 2026 08:30
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@wdconinc wdconinc requested a review from veprbl March 4, 2026 15:46
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this works

@wdconinc wdconinc changed the title Add outdated eic-shell warning for singularity/apptainer users feat: Add outdated eic-shell warning for singularity/apptainer users Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants