feat: Add outdated eic-shell warning for singularity/apptainer users#180
Open
feat: Add outdated eic-shell warning for singularity/apptainer users#180
Conversation
…cript Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add warning for users running singularity/apptainer
Add outdated eic-shell warning for singularity/apptainer users
Mar 4, 2026
wdconinc
approved these changes
Mar 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a shell-startup warning inside Singularity/Apptainer containers to help users notice when their outer eic-shell launcher script is likely stale and upgradable.
Changes:
- Introduces a new
profile.dstartup script that conditionally warns on interactive shells inside Singularity/Apptainer. - Detects an upgradable outer
eic-shellscript (exists, writable) and checks whether its mtime is older than ~180 days. - Prints guidance to run
eic-shell --upgradeoutside the container when triggered.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users running inside singularity/apptainer have no way to know their outer
eic-shellscript is stale—there's no automatic update mechanism once it's installed. Add a startup warning when the script can be upgraded.Changes
containers/eic/profile.d/z15_singularity_update.sh: sourced at shell startup; warns when all of the following hold:$SINGULARITY_CONTAINERor$APPTAINER_CONTAINERis set)$EIC_SHELL_PREFIX/../eic-shellexists and is writable by the current userWhen triggered, the warning suggests:
The write-access check gates the warning—if the user can't upgrade, there's no point in warning them.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.