Enforce strict runtime secrets, add env loader, and make DB setup explicit#52
Closed
Enforce strict runtime secrets, add env loader, and make DB setup explicit#52
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
lib/env-loader.tsand applies a policy (.env.localfor local-dev,.envfor docker-compose) with precedenceprocess.env > primary > secondaryand helperloadEnvWithPolicy.lib/env-security.tsanddocker-entrypoint.shto fail fast in production when secrets are missing, too short, placeholder-like, or obviously default.docker-compose.ymlto require critical vars at container start (uses:${VAR:?message}) and removes dangerous default credentials.lib/setup-secrets.tsto write generated values to the active env file based on policy and to generate VAPID keys; README and.env.examplewere updated to surface the new policy and placeholders.scripts/db-setup.tsnow acceptsinit-dev(SQLite bootstrap) ormigrate-prod(PostgreSQL migrate deploy) and uses the env loader to resolveDATABASE_URL;package.jsonscripts were updated accordingly andpostinstallnow runsprisma generate.docker-entrypoint.shto use a stricter validator, fail fast on missingprismaCLI or failed migrations in production, and provide clearer logging and error handling.Testing
npm run lintand static checks, which passed.npm test(Vitest) against the modified modules, which passed.npm run db:init:dev(SQLite path) andnpm run db:migrate:prod(Postgres path) in a CI-like environment; both completed the expected steps (schema generation and migration) without errors.Codex Task