Fix compatibility with TypeScript 6 or 7#1390
Open
pxseu wants to merge 1 commit into
Open
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
@pxseu is attempting to deploy a commit to the EGOIST's projects Team on Vercel. A member of the Team first needs to authorize it. |
pxseu
changed the title
|
I've also confirmed that this patch unbreaks This looks like a very effective fix, since it still passes I'd like to implore the maintainers to merge this and include it in a release, rather than continuing to sit on it. |
lgarron
added a commit
to cubing/cubing.js
that referenced
this pull request
Mar 31, 2026
This was referenced Apr 5, 2026
Closed
mcarter-astronautdev
added a commit
to DriverDigital/vite-plugin-shopify-clean
that referenced
this pull request
Apr 17, 2026
tsup unconditionally sets baseUrl when generating .d.ts files, which triggers TS5101 in TypeScript 6. Adding ignoreDeprecations until tsup merges egoist/tsup#1390.
This was referenced Apr 21, 2026
4 tasks
4 tasks
TylerBarnes
added a commit
to mastra-ai/mastra
that referenced
this pull request
Apr 29, 2026
## Description Upgrade TypeScript from `5.9.3` to `6.0.3` across the monorepo. TS 6 is the last JS-based release before the Go-based TS 7 — this upgrade prepares the codebase for the eventual v7 migration. ### What changed **Version bump:** - pnpm catalog: `^5.9.3` → `^6.0.3` **Deprecated option removals (TS 6 deprecations → errors in TS 7):** - Removed `baseUrl` from 5 tsconfig files (playground-ui, playground, react SDK) — `paths` now resolves relative to the tsconfig without `baseUrl` - Removed `baseUrl` from 3 e2e test template tsconfigs (no-bundling, monorepo app, inner-tools) - Updated root `tsconfig.json` `moduleResolution` from `"Node"` (alias for deprecated `Node10`) to `"bundler"` **@types auto-discovery (TS 6 breaking change):** - Added `"types": ["node"]` to `tsconfig.node.json` (base config for most packages) - Added `"types": ["node"]` to standalone tsconfigs that don't extend `tsconfig.node.json` (`mcp-registry-registry`, `create-mastra`, `memory/integration-tests`, `playground/e2e/kitchen-sink`) - Added `"types": ["node"]` to e2e test templates (`commonjs`, `no-bundling`, `type-check`) **Build fixes:** - Patched `tsup@8.5.1` to fix `baseUrl` deprecation error in DTS builder (upstream [egoist/tsup#1388](egoist/tsup#1388), unmerged [fix PR #1390](egoist/tsup#1390)) - Fixed `convex` and `elasticsearch` `tsconfig.build.json` to properly extend local `tsconfig.json` (matching all other stores) **Code fixes:** - Removed 2 now-unused `@ts-expect-error` directives in `packages/core` for `ReadableStream` async iteration (natively supported in TS 6's ES2025 lib) - Added type assertion for `Response.json()` return in `mcp-docs-server` (now returns `Promise<unknown>` instead of `Promise<any>`) - Fixed type narrowing in `editor/processor-graph-hydrator.ts` for `.parallel()` and `.map()` calls ### Verified locally - **Full monorepo build**: 122/122 tasks pass — all `.d.ts` generation works correctly - **Typecheck**: all packages pass - **Lint**: 112/112 tasks pass - **E2E tests**: monorepo + no-bundling suites pass locally ## Type of Change - [x] Code refactoring ## Checklist - [x] I have made corresponding changes to the documentation (if applicable) - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have addressed all Coderabbit comments on this PR Link to Devin session: https://app.devin.ai/sessions/286c1e429f144e4eb8f4a69033a347fd Requested by: @TylerBarnes --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: tyler <tylerdbarnes@gmail.com>
pgerke
added a commit
to lion-and-bear/freeathome-local-api-client
that referenced
this pull request
May 16, 2026
egoist/tsup#1390 Signed-off-by: Philip Gerke <me@philipgerke.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
#1389
#1388
Tested as a monkey patch here:
pxseu/fami@08c396d
https://github.com/pxseu/fami/actions/runs/23560643308/job/68599308721#step:5:9