Skip to content

Fix uninitialised value#1845

Closed
michaelortmann wants to merge 2 commits intoeggheads:developfrom
michaelortmann:family
Closed

Fix uninitialised value#1845
michaelortmann wants to merge 2 commits intoeggheads:developfrom
michaelortmann:family

Conversation

@michaelortmann
Copy link
Copy Markdown
Member

Found by: https://github.com/michaelortmann/
Patch by: https://github.com/michaelortmann/
Fixes:

One-line summary:

Additional description (if needed):

Test cases demonstrating functionality (if applicable):
> valgrind --track-origins=yes ./eggdrop -t BotA.conf
Then telnet to the bot

[...]
[06:40:18] Telnet connection: localhost.home.arpa/43372
==545660== Conditional jump or move depends on uninitialised value(s)
==545660==    at 0x402B970: dcc_telnet_hostresolved (dcc.c:1403)
==545660==    by 0x40300A2: dns_dcchostbyip (dns.c:164)
==545660==    by 0x4030CDA: call_hostbyip (dns.c:439)
==545660==    by 0x403F8EF: sockread (net.c:1067)
==545660==    by 0x403FC56: sockgets (net.c:1178)
==545660==    by 0x4036FB4: mainloop (main.c:765)
==545660==    by 0x4038305: main (main.c:1223)

==545660== Uninitialised value was created by a stack allocation
==545660== at 0x402B403: dcc_telnet_hostresolved (dcc.c:1318)
==545660==
[06:40:18] net: eof!(write) socket 11 (Broken pipe,32)
[06:40:18] EOF ident connection

michaelortmann added a commit to michaelortmann/eggdrop that referenced this pull request Oct 22, 2025
@vanosg vanosg added this to the v1.10.2 milestone Apr 18, 2026
Copy link
Copy Markdown
Member

@thommey thommey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelortmann
Copy link
Copy Markdown
Member Author

OBE - already fixed by in branch develop when #1467 was merged

@vanosg vanosg removed this from the v1.10.2 milestone Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants