Open
Conversation
QualOps Code Quality AnalysisStatus: Summary
🟡 Medium Issues (1)
📊 Full ReportPowered by QualOps |
valdis
force-pushed
the
observability-instrumentation
branch
from
ce71577 to
ff79ddc
Compare
nherment
requested changes
Apr 10, 2026
There was a problem hiding this comment.
Looks okish. It doesn't look like this PR was self-reviewed.
Some comments, those with a * are blocking the PR:
- In the future, please share smaller PRs, easier to digest and review.
*obsCtxis passed down as argument. I'm pretty sure you only need to manually connect a span to a parent at the boundary of the program, which at this stage should not be needed in qualops.*In at least some instances, spans can be left dangling because they manually wrap code that can throw and are neither usingwithSpannor are they wrapping the exception code with a try/finally.
Collaborator
|
If you're stacking PRs, can you make sure the commits are identical and chain them by branch? This PR has a lot of commits it doesn't need. |
valdis
force-pushed
the
validate-config
branch
2 times, most recently
from
013e3c5 to
4d98423
Compare
Add distributed tracing to the multi-stage review pipeline using @opentelemetry/api with @langfuse/otel as the OTLP backend. Traces both file-by-file mode (job → pass → file-review generations) and agentic mode (job → per-turn generations). Migrate eval runner from direct Langfuse SDK tracing to OTel, keeping Langfuse SDK for dataset management and scoring APIs only.
valdis
force-pushed
the
observability-instrumentation
branch
from
ff79ddc to
60e23d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Langfuse observability for the review pipeline.
Traces per run with per-job, per-pass, and per-file-review generations (token usage, latency, cost)
Set both keys (no other configuration needed — QualOps auto-detects them):
LANGFUSE_SECRET_KEY=sk-lf-... LANGFUSE_PUBLIC_KEY=pk-lf-... # Optional — defaults to https://cloud.langfuse.com LANGFUSE_BASE_URL=https://your-self-hosted-langfuse.example.comSession grouping
Traces are grouped by
sessionId. When running in CI, QualOps derives the session from PR metadata (GITHUB_REPOSITORY+ head SHA, orCI_PROJECT_PATH+ head SHA for GitLab). Outside CI, the session falls back to the local run name. This lets you view all traces for a PR in Langfuse's Sessions view.Supported CI env vars:
GITHUB_REPOSITORY,PR_NUMBER/GITHUB_PR_NUMBER(GitHub Actions)CI_PROJECT_PATH,CI_MERGE_REQUEST_IID(GitLab CI)