Skip to content

Hide data table#173

Merged
avoinea merged 3 commits into
masterfrom
develop
Sep 15, 2025
Merged

Hide data table#173
avoinea merged 3 commits into
masterfrom
develop

Conversation

@razvanMiu
Copy link
Copy Markdown
Contributor

No description provided.

@razvanMiu razvanMiu requested a review from avoinea September 15, 2025 10:54
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR implements a simple but significant UI change to the Volto Plotly Charts add-on by hiding the data table section from view. The change adds an inline CSS style display: 'none' to the figure data table wrapper div in the PlotlyComponent.

The data table section contains important metadata including chart information, data provenance, temporal coverage, geographical coverage, and publisher details. While this information is still being processed and rendered in the DOM, it's now completely hidden from users. This approach maintains all existing functionality while removing visual elements that may have been deemed unnecessary or cluttering the interface.

This change fits into the broader Volto ecosystem as a presentation layer modification that doesn't affect the underlying data processing or chart rendering capabilities. The PlotlyComponent continues to handle all chart operations normally, but the supplementary data table information is simply not displayed to end users.

Important Files Changed

Changed Files
Filename Score Overview
src/PlotlyComponent/PlotlyComponent.jsx 4/5 Added inline style to hide the figure data table wrapper div

Confidence score: 4/5

  • This PR is safe to merge with minimal risk as it only affects visual presentation without changing functionality
  • Score reflects the simplicity of the change and low likelihood of breaking existing features
  • Pay attention to src/PlotlyComponent/PlotlyComponent.jsx to ensure the hidden data table doesn't impact accessibility or SEO requirements

Sequence Diagram

sequenceDiagram
    participant User
    participant PlotlyComponent
    participant VisibilitySensor
    participant ConnectedPlotlyComponent
    participant Plot
    participant Toolbar
    participant EmbedData
    participant Redux
    participant DataProvider

    User->>PlotlyComponent: "Load page with chart"
    PlotlyComponent->>VisibilitySensor: "Wrap component"
    VisibilitySensor->>ConnectedPlotlyComponent: "Initialize when visible"
    
    ConnectedPlotlyComponent->>Redux: "Connect to state"
    ConnectedPlotlyComponent->>DataProvider: "Fetch visualization data"
    DataProvider-->>ConnectedPlotlyComponent: "Return provider_data"
    
    ConnectedPlotlyComponent->>ConnectedPlotlyComponent: "Process filters and data"
    ConnectedPlotlyComponent->>Plot: "Render chart with data/layout"
    Plot-->>ConnectedPlotlyComponent: "onInitialized callback"
    
    ConnectedPlotlyComponent->>Toolbar: "Render toolbar with chart data"
    ConnectedPlotlyComponent->>EmbedData: "Render hidden data table"
    EmbedData->>EmbedData: "Set display: none on table"
    
    User->>ConnectedPlotlyComponent: "Change filter selection"
    ConnectedPlotlyComponent->>ConnectedPlotlyComponent: "Update filtersState"
    ConnectedPlotlyComponent->>Plot: "Re-render with filtered data"
    
    User->>Toolbar: "Click toolbar action"
    Toolbar->>Plot: "Trigger chart interaction"
Loading

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@avoinea avoinea merged commit 6c5ab8e into master Sep 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants