fix(diagnostics): eglot with flycheck vs flymake#226
Merged
ericdallo merged 2 commits intoeditor-code-assistant:masterfrom Apr 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
editor_diagnosticsfailed with Symbol's function definition is void: flymake-diagnostic-code and it happens when running eglot + flycheck (no lsp-mode).Suggested solution:
checking if flycheck is the active tool used before running the flymake diagnostics.
Current workaround in my Emacs setup:
Note: the changes in this PR were created by Eca with the Opus 4.7 model - with me steering. I am not confident in my Elisp skills as I am in Python, though.