Skip to content

fix(diagnostics): eglot with flycheck vs flymake#226

Merged
ericdallo merged 2 commits intoeditor-code-assistant:masterfrom
DavidVujic:fix-eglot-with-flycheck-vs-flymake
Apr 23, 2026
Merged

fix(diagnostics): eglot with flycheck vs flymake#226
ericdallo merged 2 commits intoeditor-code-assistant:masterfrom
DavidVujic:fix-eglot-with-flycheck-vs-flymake

Conversation

@DavidVujic
Copy link
Copy Markdown
Contributor

@DavidVujic DavidVujic commented Apr 22, 2026

The editor_diagnostics failed with Symbol's function definition is void: flymake-diagnostic-code and it happens when running eglot + flycheck (no lsp-mode).

Suggested solution:
checking if flycheck is the active tool used before running the flymake diagnostics.

Current workaround in my Emacs setup:

(with-eval-after-load 'eca-editor
  (defun eca-editor--flymake-diagnostics (_uri _workspace)
    "Neutralized: flycheck-eglot already bridges eglot diagnostics into flycheck."
    nil))

Note: the changes in this PR were created by Eca with the Opus 4.7 model - with me steering. I am not confident in my Elisp skills as I am in Python, though.

@DavidVujic DavidVujic marked this pull request as ready for review April 22, 2026 09:07
@DavidVujic DavidVujic changed the title wip(diagnostics): eglot with flycheck vs flymake fix(diagnostics): eglot with flycheck vs flymake Apr 22, 2026
Copy link
Copy Markdown
Member

@ericdallo ericdallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@ericdallo ericdallo merged commit 89b51cc into editor-code-assistant:master Apr 23, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants