docs(code): add principle and pattern guidelines with skill restructuring#1871
Merged
docs(code): add principle and pattern guidelines with skill restructuring#1871
Conversation
…ring Establish comprehensive code guidelines by extracting principles and patterns into dedicated docs, replacing monolithic files with focused, discoverable documents. - Add 7 principle docs (SRP, OCP, Law of Demeter, Validate at Edge, Type-Driven Design, Idempotency, IoC) - Add 3 pattern docs (Builder, Service, Typestate) replacing `rust-service.md` and `rust-types.md` - Rename skills for consistency: `code-pattern-discovery` → `code-discovery`, `code-pattern-fmt-check` → `docs-code-fmt-check`, `feature-fmt-check` → `docs-features-fmt-check` - Update AGENTS.md with mandatory principles table and revised skill references - Add meta specs for code-pattern and code-principle doc formats Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
mitchhs12
reviewed
Feb 26, 2026
| ## Query Matching Guidelines | ||
|
|
||
| ### Pattern Types | ||
| ### Guideline Types |
Contributor
There was a problem hiding this comment.
Why make this change from 'Pattern' to 'Guideline'? Does it offer any benefits?
I would have thought 'Pattern' is more explicit and unequivocal for Claude.
Contributor
Author
There was a problem hiding this comment.
Because it is a more generic term for what the docs/code/ section contains.
Now, it also contains "coding principles". Those are not design patterns. Those are guidelines and best practices.
fubhy
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Establish comprehensive code guidelines by extracting principles and patterns into dedicated docs, replacing monolithic files with focused, discoverable documents.
rust-service.mdandrust-types.mdcode-pattern-discovery→code-discovery,code-pattern-fmt-check→docs-code-fmt-check,feature-fmt-check→docs-features-fmt-check