Skip to content

fix(evm-rpc): add request timeouts#1869

Merged
Theodus merged 1 commit intomainfrom
theodus/provider-timeout
Feb 25, 2026
Merged

fix(evm-rpc): add request timeouts#1869
Theodus merged 1 commit intomainfrom
theodus/provider-timeout

Conversation

@Theodus
Copy link
Member

@Theodus Theodus commented Feb 25, 2026

This should avoid raw dataset materialize jobs getting stuck indefinitely for no reason visible in logs.

@Theodus Theodus requested review from LNSD and sistemd February 25, 2026 16:53
@Theodus Theodus force-pushed the theodus/provider-timeout branch from b8acf4f to ec61c9c Compare February 25, 2026 17:36
@Theodus Theodus merged commit 8220348 into main Feb 25, 2026
9 checks passed
@Theodus Theodus deleted the theodus/provider-timeout branch February 25, 2026 18:15
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you address this in a follow-up PR? 🙏

url: Url,
auth: Option<Auth>,
rate_limit: Option<NonZeroU32>,
timeout_secs: u64,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this Duration?

batch_size: usize,
rate_limit: Option<NonZeroU32>,
fetch_receipts_per_tx: bool,
timeout_secs: u64,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

///
/// Default: 30 seconds
#[serde(default = "default_timeout_secs")]
pub timeout_secs: u64,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we deserikize directly into Duration. Maybe using serde_with.

@Theodus
Copy link
Member Author

Theodus commented Feb 25, 2026

@LNSD fixed in #1870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants