Draft
Conversation
LNSD
force-pushed
the
lnsd/feat-common-amp-async-catalog
branch
from
d85dd84 to
e6efa27
Compare
LNSD
changed the title
LNSD
force-pushed
the
lnsd/feat-common-amp-async-catalog
branch
12 times, most recently
from
43ec896 to
7037315
Compare
…ring Establish comprehensive code guidelines by extracting principles and patterns into dedicated docs, replacing monolithic files with focused, discoverable documents. - Add 7 principle docs (SRP, OCP, Law of Demeter, Validate at Edge, Type-Driven Design, Idempotency, IoC) - Add 3 pattern docs (Builder, Service, Typestate) replacing `rust-service.md` and `rust-types.md` - Rename skills for consistency: `code-pattern-discovery` → `code-discovery`, `code-pattern-fmt-check` → `docs-code-fmt-check`, `feature-fmt-check` → `docs-features-fmt-check` - Update AGENTS.md with mandatory principles table and revised skill references - Add meta specs for code-pattern and code-principle doc formats Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
Restructure session construction to resolve table and function catalogs lazily, eliminating eager registration that caused isolate-pool hangs. - Build and operate on `SessionState` directly instead of transient `DFSessionContext` - Add `AmpCatalogProvider` and `DatasetSchemaProvider` for async-resolved catalog entries - Plumb real `IsolatePool` through all resolution paths to prevent dummy-pool hangs - Flatten session error types into `DataFusionError` with `Context`-based user-input tagging - Parallelize table and function resolution under a shared concurrency semaphore Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
lnsd/feat-common-amp-async-catalog
branch
from
7037315 to
b195c35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
🚧 This is under heavy development 🚧