feat: document circuit breaker config options for targets#37
Open
feat: document circuit breaker config options for targets#37
Conversation
Add commented-out circuit_breaker section to the default worker_pool target showing failure_threshold and open_timeout_secs with defaults. The config is passed through to bits via toYaml and requires no template changes.
There was a problem hiding this comment.
Pull request overview
Documents per-target circuit breaker configuration options in the Helm chart’s default broker target definition, making it easier for operators to discover and enable circuit breaking.
Changes:
- Adds a commented-out
circuit_breakerblock underbroker.targets.worker_poolinvalues.yamldescribing available knobs (failure_threshold,open_timeout_secs).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change
Add commented-out
circuit_breakersection tovalues.yamlunder theworker_pooltarget. No template changes needed since targets are passed through viatoYaml.Operators uncomment and adjust values to enable per-target circuit breaking. When a target fails
failure_thresholdtimes consecutively (connection errors, timeouts, 5xx), the broker stops sending requests foropen_timeout_secs, then allows one probe request to test recovery.Contributor Declaration
By opening this pull request, I affirm the following: